google / google/go-containerregistry

Restructure k8schain imports

Open
#1,042 3 comments 1 reaction 0 assignees View on GitHub
lifecycle/frozen
Dominant language
Go
Stars
4k
Forks
686
Avg merge
2d 12h
Merged PRs (30d)
26

Description

We do side-effectual imports in k8schain to pull in cloud-specific credential providers. We currently have build tags to disable importing specific things in k8schain. This seems backwards.

Callers should be responsible for importing these magic packages, not k8schain, which would make the dependency graph a little less stupid.

Contributor guide

Open the contributing guide

Research direction

Start at the k8schain entry point and trace its side-effect imports, build-tag exclusions, and callers that rely on cloud-specific credential providers. Done means the dependency responsibility is moved to callers without k8schain-owned magic imports, with the affected import paths and build configurations still working.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, cloud
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.