google / google/gnostic

Util package jsonwriter do not handle escape and null value

Open
#418 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.3k
Forks
279
PR merge metrics
No merged PRs in 30d

Description

1. [escape](https://github.com/google/gnostic/blob/main/jsonwriter/writer.go#L29) only handle `\n` and `"`

`\` should be escape also because some comment description contains it

2. [scalar write](https://github.com/google/gnostic/blob/main/jsonwriter/writer.go#L86) does not handle `!!null` and it would cause empty `null` value in jsonwrite

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.