google / google/git-appraise

Handle Comment on Simultaneous Reviews Request

Open
#117 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
5.3k
Forks
148
PR merge metrics
No merged PRs in 30d

Description

I'm currently Implementing a git-appraise extension for VSCode and I'd like to clarify the following:

- It's impossible to have simultaneous opened review on a commit => can we use `comment.parent` to point to the parent request sha1 ? similar to what is currently done on the comment-comment relation.

- `git-appraise list -a` report an empty list on git 1.8.3.1 (RHEL7)
- Why message schema don't specify that lines/columns location are 1-based
- Are `additionalProperties` allowed on the request and message JSON ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.