google / google/gapid

Cleanup State.preMutate - make EGL into proper API?

Open
#924 3 comments 0 reactions 0 assignees View on GitHub
GAPIS P3 triaged
Dominant language
Go
Stars
2.2k
Forks
329
PR merge metrics
No merged PRs in 30d

Description

Regarding #920 - I agree that doing string prefix check to determine API is nasty. (On the other hand, I think having one place to put common preMutate code without manual or automatic copy-paste is desirable)

One solution here would be to split EGL into its own API, as it probably should be.

We could also consider moving the preMutate function into the api file.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.