google / google/gapid

We need to extend the coherent memory tracker to deal with swiftshader more easily.

Open
#3,163 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
2.2k
Forks
329
PR merge metrics
No merged PRs in 30d

Description

Swiftshader writes to coherent memory from the CPU (Because it is a CPU implementation of the driver).
We will catch those writes, and treat them as application writes, this will give us odd behavior.

Instead, we should either a) detect CPU implementations of the driver, and turn off the coherent memory tracker, or better yet, detect when these calls are coming from within the driver (if possible). Likeley the first for now.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.