google / google/gapid

Maths for framebuffer histogram looks broken

Open
#2,855 3 comments 0 reactions 0 assignees View on GitHub
bug P2 triaged
Dominant language
Go
Stars
2.2k
Forks
329
No merged PRs in 30d

Description

The maths for setting the bottom and top end of the histogram in the framebuffer viewer looks incorrect. If you lower the top end of the display range, the image progressively desaturates. Is this correct behaviour?

![histo1](https://user-images.githubusercontent.com/51710753/59931900-e3f65b80-943d-11e9-9326-2c68a45e9d4f.png)
![histo2](https://user-images.githubusercontent.com/51710753/59931901-e3f65b80-943d-11e9-9042-5e0f2f483588.png)
![histo3](https://user-images.githubusercontent.com/51710753/59931902-e3f65b80-943d-11e9-8887-5ef3514501ea.png)
![histo4](https://user-images.githubusercontent.com/51710753/59931903-e3f65b80-943d-11e9-8815-165d1814ef97.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.