google / google/gapid

Extras stored to describe capture device capabilities are used by replay

Open
#2,101 0 comments 0 reactions 0 assignees View on GitHub
cleanup P3 triaged Vulkan
Dominant language
Go
Stars
2.2k
Forks
329
PR merge metrics
No merged PRs in 30d

Description

As noted [in this PR](https://github.com/google/gapid/pull/2097#issuecomment-408620292), there are a number of extras that are being stored into the capture to describe the **traced device** capabilities. These extras are then used to decide how to generate the **replay**.

This is all a bit backwards - we should no assumptions that the replay device is the same as the one used for tracing. If we need to dynamically generate replay logic based on the replay device capabilities, then we should be storing this information in the [`VulkanDriver` structure of the device](https://github.com/google/gapid/blob/master/core/os/device/device.proto#L214). By doing this, you'll get this information in the capture header as well as for the replay device.

[There are already examples of this for GLES](https://github.com/google/gapid/blob/master/core/os/device/device.proto#L205).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.