google / google/gapid

gapii doesn't initialize the logger.

Open
#1,537 2 comments 0 reactions 1 assignee Claimed by @ben-clayton View on GitHub
debugging GAPII P3 question triaged
Dominant language
Go
Stars
2.2k
Forks
329
PR merge metrics
No merged PRs in 30d

Description

The logging system needs to be initialized with `GAPID_LOGGER_INIT`, but gapii doesn't call that macro. On Android this is no problem, since that macro is empty anyhow, but on desktop tracing, not calling this macro essentially disables gapii logging.

I'm not sure where to add it, I was thinking:
```
GAPID_LOGGER_INIT(LOG_LEVEL, "gapii", "logs/gapii.log");
```
in `gapii/cc/spy.cpp` in the `Spy::get` function.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.