google / google/fuzztest

setup_configs should respect deprecation of _LIBCPP_ENABLE_ASSERTIONS

Open
#2,018 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.1k
Forks
137
Avg merge
3d 6h
Merged PRs (30d)
22

Description

_LIBCPP_ENABLE_ASSERTIONS is deprecated in favor of hardening modes.
In my local setup I had to manually change
```
build:fuzztest-common --copt=-D_LIBCPP_ENABLE_ASSERTIONS=1
```
to
```
build:fuzztest-common --copt=-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE`
```

For my clang to not emit a compilation error.

I hope there is a way to automatically generate this with https://github.com/google/fuzztest/blob/main/bazel/setup_configs.sh so that I don't have to manually modify the generated file.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.