google / google/fuzztest

[CMake] sanitizer is forced to "address sanitizer"

Open
#1,124 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
1.1k
Forks
137
Avg merge
3d 6h
Merged PRs (30d)
22

Description

In fuzzing mode or compatibility mode, address sanitizer is forced.
https://github.com/google/fuzztest/blob/a990537097b6fd337436f7662fb39fc91fa01f3f/cmake/FuzzTestFlagSetup.cmake#L2-L3

This is problematic on oss-fuzz which has different sanitizers. We therefore remove those flags https://github.com/AOMediaCodec/libavif/blob/d074bae4b0b1d7423d102f6d9d5e0c5303971a51/ext/fuzztest.cmd#L14 and use the ones set in the environment variable `CXXFLAGS` by oss-fuzz.

I believe those sanitizer flags should only be set for `FUZZTEST_FUZZING_MODE`, not when `FUZZTEST_COMPATIBILITY_MODE STREQUAL "libfuzzer")`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.