google / google/fonts

{Open Sans} combination of two Hebrew diacritics (niqqud) are offset by wrong kerning pairs

Open
#9,415 7 comments 0 reactions 0 assignees View on GitHub
I Font Bug
Dominant language
HTML
Stars
20.5k
Forks
2.9k
Avg merge
1d 21h
Merged PRs (30d)
95

Description

**Describe the bug**

The bug relates to wrongly configured kerning pairs in Open Sans's Hebrew niqqud diacritics (the Hebrew vowels system), specifically the combination of dagesh diacritic and one of the other niqqud vowels. In such cases, the niqqud vowel is offset past the end of the of the vowelled character (to the left) regardless of the order in which the diacritics are entered. The only exception is the combination of dagesh and holam, which I suspect is because holam is supposed to be offset left of the character.

**To Reproduce**

https://fonts.google.com/specimen/Open+Sans?preview.text=%D7%AA%D6%B7%20%D7%AA%D6%B7%D6%BC%20%D7%AA%D6%B7%D6%BC%20%D7%AA%D6%B9%D6%BC

The above example shows the letter taw, once vowelled with the patch diacritic (correct position of the patach), once vowelled with a patach followed by a dagesh, one vowelled by a dagesh followed by a patach (both displaying an offset patach), and one vowelled by a dagesh and holam (correct).

**Expected behavior**

Kerning pairs should be configured so that niqqud is correctly positioned regardless of the presence of a dagesh.

**Screenshots**

_Current behavior (offest):_
![Image](https://github.com/user-attachments/assets/4fd33a3c-0766-46f1-8d2d-99af3a0e93f6)

_Expected behabior:_
![Image](https://github.com/user-attachments/assets/6821b47e-8b49-44f1-82bc-205473f62cb5)

**Additional context**

Tested in Chrome and Firefox on both MacOS Sequoia (15.4.1) and Windows 10, as well as in Adobe InDesign on a Mac.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.