google / google/fonts

Playwrite `primary_language`: question/discussion

Open
#8,724 9 comments 0 reactions 0 assignees View on GitHub
-- Needs Eng team opinion I API / Website / Platform
Dominant language
HTML
Stars
20.5k
Forks
2.9k
Avg merge
1d 21h
Merged PRs (30d)
95

Description

cc @vv-monsalve

I have the feeling that some of localised primary language like `primary_language: "fr_Latn"` doesn't work everywhere. For French, it works in the Guides versions, but not on the normal one. It's weird since both of metadata.pb have the primary_language [set up](https://github.com/google/fonts/blob/e5c2b48b7bb4e2d910f9341c0364bb304329a3be/ofl/playwritefrtrad/METADATA.pb#L52C1-L52C28).

For Argentina, Guides version isn't displayed in spanish, but I checked and the `primary_language: "es_Latn"` is missing from [metadata.pb](https://github.com/google/fonts/blob/e5c2b48b7bb4e2d910f9341c0364bb304329a3be/ofl/playwritearguides/METADATA.pb#L46) (same for Colombia)

![Image](https://github.com/user-attachments/assets/86b7602f-232f-4ad2-a982-3d6b7e55097e)
![Image](https://github.com/user-attachments/assets/4dfbb554-df4e-4f52-9721-1838ad2087f7)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.