google / google/fonts

Font URL fails to validate

Open
#5,892 0 comments 0 reactions 0 assignees View on GitHub
-- Needs Eng team opinion I API / Website / Platform
Dominant language
HTML
Stars
20.5k
Forks
2.9k
Avg merge
1d 21h
Merged PRs (30d)
95

Description

In the generated HTML code for embedding fonts, the href attribute contains an ampersand that HTML validation treats as an entity code. The href attribute for the generated link tag includes & characters that cause validation to fail.

To reproduce, generate the HTML code for the Fira Sans Regular 400 font, embed it in a web page and check the source with an HTML validator, such as "tidy".

I would expect this to properly validate, but it does not and gives:

line 17 column 101 - Warning: unescaped & or unknown entity "&display"

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.