google / google/fonts

Double check METADATA subset keys in all recently touched families

Open
#3,823 2 comments 1 reaction 1 assignee Claimed by @m4rc1e View on GitHub
Dominant language
HTML
Stars
20.5k
Forks
2.9k
Avg merge
1d 21h
Merged PRs (30d)
95

Description

RockNRoll's METADATA subsets list got corrupted, adding Chinese subsets which is super bad because if it reaches production it will create a lot of tofu, and its very difficult to remove a subset once added.

When I was triaging this I found the METADATA file I had was fine, but actually it was because I was on a stale repo commit locally, and pulling the repo surfaced the issue.

So, the immediate issue is all the metadata files added in that pull need careful manual review for similar bad additions.

I guess this is due to the add_font script being used as if it was fully reliable when it isn't, so the long term issue is to figure out the process issue that led to this and change the process so this won't happen again.

```
$ grep subset ofl/rocknrollone/METADATA.pb
subsets: "cyrillic"
subsets: "japanese"
subsets: "latin"
subsets: "latin-ext"
subsets: "menu"

$ git pull
Updating 659cb68b..737d000f
Fast-forward
...
539 files changed, 4750 insertions(+), 1328 deletions(-)
create mode 100644 .github/workflows/report.yaml
create mode 100644 lang/languages/aii_Armi.textproto
create mode 100644 lang/languages/aii_Brah.textproto
create mode 100644 lang/languages/aii_Chrs.textproto
create mode 100644 lang/languages/aii_Egyp.textproto
create mode 100644 lang/languages/aii_Elym.textproto
create mode 100644 lang/languages/aii_Hatr.textproto
create mode 100644 lang/languages/aii_Mani.textproto
create mode 100644 lang/languages/aii_Narb.textproto
create mode 100644 lang/languages/aii_Nbat.textproto
create mode 100644 lang/languages/aii_Palm.textproto
create mode 100644 lang/languages/aii_Phli.textproto
create mode 100644 lang/languages/aii_Phlp.textproto
create mode 100644 lang/languages/aii_Phnx.textproto
create mode 100644 lang/languages/aii_Prti.textproto
create mode 100644 lang/languages/aii_Samr.textproto
create mode 100644 lang/languages/aii_Sarb.textproto
create mode 100644 lang/languages/aii_Sogd.textproto
create mode 100644 lang/languages/aii_Sogo.textproto
create mode 100644 lang/languages/aii_Ugar.textproto
create mode 100644 ofl/angkor/upstream.yaml
create mode 100644 ofl/areyouserious/AreYouSerious-Regular.ttf
create mode 100644 ofl/areyouserious/DESCRIPTION.en_us.html
create mode 100644 ofl/areyouserious/METADATA.pb
create mode 100644 ofl/areyouserious/OFL.txt
create mode 100644 ofl/areyouserious/upstream.yaml
rename ofl/{azeret => azeretmono}/AzeretMono-Italic[wght].ttf (100%)
rename ofl/{azeret => azeretmono}/AzeretMono[wght].ttf (100%)
rename ofl/{azeret => azeretmono}/DESCRIPTION.en_us.html (100%)
rename ofl/{azeret => azeretmono}/METADATA.pb (100%)
rename ofl/{azeret => azeretmono}/OFL.txt (100%)
rename ofl/{azeret => azeretmono}/upstream.yaml (100%)
create mode 100644 ofl/battambang/Battambang-Black.ttf
create mode 100644 ofl/battambang/Battambang-Light.ttf
create mode 100644 ofl/battambang/Battambang-Thin.ttf
create mode 100644 ofl/battambang/upstream.yaml
create mode 100644 ofl/bayon/upstream.yaml
delete mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay-Black.ttf
delete mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay-Bold.ttf
delete mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay-ExtraBold.ttf
delete mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay-Light.ttf
delete mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay-Medium.ttf
delete mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay-Regular.ttf
delete mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay-SemiBold.ttf
delete mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay-Thin.ttf
create mode 100644 ofl/bigshouldersdisplay/BigShouldersDisplay[wght].ttf
delete mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay-Black.ttf
delete mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay-Bold.ttf
delete mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay-ExtraBold.ttf
delete mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay-Light.ttf
delete mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay-Medium.ttf
delete mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay-Regular.ttf
delete mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay-SemiBold.ttf
delete mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay-Thin.ttf
create mode 100644 ofl/bigshouldersinlinedisplay/BigShouldersInlineDisplay[wght].ttf
delete mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText-Black.ttf
delete mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText-Bold.ttf
delete mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText-ExtraBold.ttf
delete mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText-Light.ttf
delete mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText-Medium.ttf
delete mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText-Regular.ttf
delete mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText-SemiBold.ttf
delete mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText-Thin.ttf
create mode 100644 ofl/bigshouldersinlinetext/BigShouldersInlineText[wght].ttf
delete mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay-Black.ttf
delete mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay-Bold.ttf
delete mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay-ExtraBold.ttf
delete mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay-Light.ttf
delete mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay-Medium.ttf
delete mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay-Regular.ttf
delete mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay-SemiBold.ttf
delete mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay-Thin.ttf
create mode 100644 ofl/bigshouldersstencildisplay/BigShouldersStencilDisplay[wght].ttf
delete mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText-Black.ttf
delete mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText-Bold.ttf
delete mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText-ExtraBold.ttf
delete mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText-Light.ttf
delete mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText-Medium.ttf
delete mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText-Regular.ttf
delete mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText-SemiBold.ttf
delete mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText-Thin.ttf
create mode 100644 ofl/bigshouldersstenciltext/BigShouldersStencilText[wght].ttf
delete mode 100644 ofl/bigshoulderstext/BigShouldersText-Black.ttf
delete mode 100644 ofl/bigshoulderstext/BigShouldersText-Bold.ttf
delete mode 100644 ofl/bigshoulderstext/BigShouldersText-ExtraBold.ttf
delete mode 100644 ofl/bigshoulderstext/BigShouldersText-Light.ttf
delete mode 100644 ofl/bigshoulderstext/BigShouldersText-Medium.ttf
delete mode 100644 ofl/bigshoulderstext/BigShouldersText-Regular.ttf
delete mode 100644 ofl/bigshoulderstext/BigShouldersText-SemiBold.ttf
delete mode 100644 ofl/bigshoulderstext/BigShouldersText-Thin.ttf
create mode 100644 ofl/bigshoulderstext/BigShouldersText[wght].ttf
create mode 100644 ofl/birthstonebounce/BirthstoneBounce-Medium.ttf
create mode 100644 ofl/birthstonebounce/BirthstoneBounce-Regular.ttf
create mode 100644 ofl/birthstonebounce/DESCRIPTION.en_us.html
create mode 100644 ofl/birthstonebounce/METADATA.pb
create mode 100644 ofl/birthstonebounce/OFL.txt
create mode 100644 ofl/birthstonebounce/upstream.yaml
create mode 100644 ofl/bokor/upstream.yaml
create mode 100644 ofl/carattere/Carattere-Regular.ttf
create mode 100644 ofl/carattere/DESCRIPTION.en_us.html
create mode 100644 ofl/carattere/METADATA.pb
create mode 100644 ofl/carattere/OFL.txt
create mode 100644 ofl/carattere/upstream.yaml
create mode 100644 ofl/cherish/Cherish-Regular.ttf
create mode 100644 ofl/cherish/DESCRIPTION.en_us.html
create mode 100644 ofl/cherish/METADATA.pb
create mode 100644 ofl/cherish/OFL.txt
create mode 100644 ofl/cherish/upstream.yaml
create mode 100644 ofl/corinthia/Corinthia-Bold.ttf
create mode 100644 ofl/corinthia/Corinthia-Regular.ttf
create mode 100644 ofl/corinthia/DESCRIPTION.en_us.html
create mode 100644 ofl/corinthia/METADATA.pb
create mode 100644 ofl/corinthia/OFL.txt
create mode 100644 ofl/corinthia/upstream.yaml
create mode 100644 ofl/dangrek/Dangrek-Regular.ttf
delete mode 100644 ofl/dangrek/Dangrek.ttf
create mode 100644 ofl/dangrek/upstream.yaml
create mode 100644 ofl/delagothicone/METADATA.pb
create mode 100644 ofl/estonia/DESCRIPTION.en_us.html
create mode 100644 ofl/estonia/Estonia-Regular.ttf
create mode 100644 ofl/estonia/METADATA.pb
create mode 100644 ofl/estonia/OFL.txt
create mode 100644 ofl/estonia/upstream.yaml
create mode 100644 ofl/fasthand/upstream.yaml
create mode 100644 ofl/faustina/upstream.yaml
create mode 100644 ofl/fleurdeleah/DESCRIPTION.en_us.html
create mode 100644 ofl/fleurdeleah/FleurDeLeah-Regular.ttf
create mode 100644 ofl/fleurdeleah/METADATA.pb
create mode 100644 ofl/fleurdeleah/OFL.txt
create mode 100644 ofl/fleurdeleah/upstream.yaml
create mode 100644 ofl/freehand/Freehand-Regular.ttf
delete mode 100644 ofl/freehand/Freehand.ttf
create mode 100644 ofl/freehand/upstream.yaml
create mode 100644 ofl/gideonroman/DESCRIPTION.en_us.html
create mode 100644 ofl/gideonroman/GideonRoman-Regular.ttf
create mode 100644 ofl/gideonroman/METADATA.pb
create mode 100644 ofl/gideonroman/OFL.txt
create mode 100644 ofl/gideonroman/upstream.yaml
create mode 100644 ofl/gluten/DESCRIPTION.en_us.html
create mode 100644 ofl/gluten/Gluten[wght].ttf
create mode 100644 ofl/gluten/METADATA.pb
rename ofl/{delagothicone => gluten}/OFL.txt (97%)
create mode 100644 ofl/gluten/upstream.yaml
create mode 100644 ofl/grechenfuemen/DESCRIPTION.en_us.html
create mode 100644 ofl/grechenfuemen/GrechenFuemen-Regular.ttf
create mode 100644 ofl/grechenfuemen/METADATA.pb
create mode 100644 ofl/grechenfuemen/OFL.txt
create mode 100644 ofl/grechenfuemen/upstream.yaml
create mode 100644 ofl/greyqo/DESCRIPTION.en_us.html
create mode 100644 ofl/greyqo/GreyQo-Regular.ttf
create mode 100644 ofl/greyqo/METADATA.pb
create mode 100644 ofl/greyqo/OFL.txt
create mode 100644 ofl/greyqo/upstream.yaml
create mode 100644 ofl/hanuman/Hanuman-Black.ttf
create mode 100644 ofl/hanuman/Hanuman-Light.ttf
create mode 100644 ofl/hanuman/Hanuman-Thin.ttf
create mode 100644 ofl/hanuman/upstream.yaml
mode change 100644 => 100755 ofl/josefinsans/OFL.txt
mode change 100644 => 100755 ofl/jura/OFL.txt
create mode 100644 ofl/kohsantepheap/DESCRIPTION.en_us.html
create mode 100644 ofl/kohsantepheap/KohSantepheap-Black.ttf
create mode 100644 ofl/kohsantepheap/KohSantepheap-Bold.ttf
create mode 100644 ofl/kohsantepheap/KohSantepheap-Light.ttf
create mode 100644 ofl/kohsantepheap/KohSantepheap-Regular.ttf
create mode 100644 ofl/kohsantepheap/KohSantepheap-Thin.ttf
create mode 100644 ofl/kohsantepheap/METADATA.pb
create mode 100644 ofl/kohsantepheap/OFL.txt
create mode 100644 ofl/kohsantepheap/upstream.yaml
create mode 100644 ofl/koulen/Koulen-Regular.ttf
delete mode 100644 ofl/koulen/Koulen.ttf
create mode 100644 ofl/koulen/upstream.yaml
mode change 100644 => 100755 ofl/kreon/OFL.txt
create mode 100644 ofl/metal/Metal-Regular.ttf
delete mode 100644 ofl/metal/Metal.ttf
create mode 100644 ofl/metal/upstream.yaml
create mode 100644 ofl/moul/Moul-Regular.ttf
delete mode 100644 ofl/moul/Moul.ttf
create mode 100644 ofl/moul/upstream.yaml
create mode 100644 ofl/moulpali/Moulpali-Regular.ttf
delete mode 100644 ofl/moulpali/Moulpali.ttf
create mode 100644 ofl/moulpali/upstream.yaml
create mode 100644 ofl/museomoderno/upstream.yaml
delete mode 100644 ofl/notosansnushu/article/placeholder.png
create mode 100644 ofl/odormeanchey/OdorMeanChey-Regular.ttf
delete mode 100644 ofl/odormeanchey/OdorMeanChey.ttf
create mode 100644 ofl/odormeanchey/upstream.yaml
mode change 100644 => 100755 ofl/oswald/OFL.txt
create mode 100644 ofl/piazzolla/upstream.yaml
create mode 100644 ofl/preahvihear/Preahvihear-Regular.ttf
delete mode 100644 ofl/preahvihear/Preahvihear.ttf
create mode 100644 ofl/preahvihear/upstream.yaml
create mode 100644 ofl/pushster/article/suspect.png
create mode 100644 ofl/reemkufi/static/ReemKufi-Bold.ttf
create mode 100644 ofl/reemkufi/static/ReemKufi-Medium.ttf
create mode 100644 ofl/reemkufi/static/ReemKufi-Regular.ttf
create mode 100644 ofl/reemkufi/static/ReemKufi-SemiBold.ttf
create mode 100644 ofl/rokkitt/upstream.yaml
create mode 100644 ofl/rubikbeastly/DESCRIPTION.en_us.html
create mode 100644 ofl/rubikbeastly/METADATA.pb
create mode 100644 ofl/rubikbeastly/OFL.txt
create mode 100644 ofl/rubikbeastly/RubikBeastly-Regular.ttf
create mode 100644 ofl/rubikbeastly/upstream.yaml
create mode 100644 ofl/rugeboogie/upstream.yaml
create mode 100644 ofl/sawarabimincho/METADATA.pb
create mode 100644 ofl/suwannaphum/Suwannaphum-Black.ttf
create mode 100644 ofl/suwannaphum/Suwannaphum-Bold.ttf
create mode 100644 ofl/suwannaphum/Suwannaphum-Light.ttf
create mode 100644 ofl/suwannaphum/Suwannaphum-Thin.ttf
create mode 100644 ofl/suwannaphum/upstream.yaml
create mode 100644 ofl/taprom/Taprom-Regular.ttf
delete mode 100644 ofl/taprom/Taprom.ttf
create mode 100644 ofl/taprom/upstream.yaml

$ grep subset ofl/rocknrollone/METADATA.pb
subsets: "chinese-simplified"
subsets: "chinese-traditional"
subsets: "cyrillic"
subsets: "japanese"
subsets: "latin"
subsets: "latin-ext"
subsets: "menu"
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.