google / google/fonts

METADATA.pb: Move `sample_text` and `sample_glyphs` to language textprotos

Open
#3,754 1 comment 0 reactions 1 assignee Claimed by @nathan-williams View on GitHub
Dominant language
HTML
Stars
20.5k
Forks
2.9k
Avg merge
1d 21h
Merged PRs (30d)
95

Description

While updating the METADATA.pb schema description on **FontBakery** (https://github.com/googlefonts/fontbakery/issues/3443) and **gf-tools** (https://github.com/googlefonts/gf-docs/issues/114), I noticed that some files such as https://github.com/google/fonts/blob/main/ofl/notosansoldpermic/METADATA.pb have `sample_text` and `sample_glyphs` entries and this seems redundant to the kind of content I see in some of the language textprotos available at https://github.com/google/fonts/blob/main/lang/languages/

On this specific case, though, https://github.com/google/fonts/blob/main/lang/languages/koi_Perm.textproto and https://github.com/google/fonts/blob/main/lang/languages/kv_Perm.textproto lack such sample entries.

The `sample_text` and `sample_glyphs` entries should (in my opinion) migrate to the language textproto files while the `languages` entries also present on the METADATA.pb file should be enough to cross-reference the lang database:
```
languages: "koi_Perm" # Komi-Permyak, Old Permic
languages: "kv_Perm" # Komi, Old Permic
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.