google / google/flogger

Flogger implementation should not read the configuration twice

Open
#20 6 comments 0 reactions 0 assignees View on GitHub
P3
Dominant language
Java
Stars
1.5k
Forks
133
Avg merge
6m
Merged PRs (30d)
7

Description

I think there is an issue in your implementation when the configuration is changed dynamically. Your implementation read the configuration twice, once in `at(Level)` and once later in `log()` so the logger can check the level of one configuration and log using another newly updated configuration.

To fix this issue, you can read the configuration once in `at()` and propagate the configuration as a parameter of the Context.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.