google / google/fleetspeak-rs

Safety violation related to the communication file descriptors

Open
#4 8 comments 0 reactions 1 assignee Claimed by @panhania View on GitHub
Dominant language
Rust
Stars
12
Forks
7
Avg merge
1d 5h
Merged PRs (30d)
4

Description

The way we [instantiate][1] `std::fs::File` objects from file descriptors passed by Fleetspeak is a violation of safety invariants as we cannot know whether it is truly valid. We should somehow verify that the descriptor is indeed valid.

[1]: https://github.com/google/fleetspeak-rs/blob/d031cfc8ee07aa0670e0040d24ab99dd689e4124/crates/fleetspeak/src/lib.rs#L270-L281

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.