google / google/flax

Updating examples/nlp_seq

Open
#568 6 comments 0 reactions 1 assignee Claimed by @bohnetbd View on GitHub
Priority: P1 - soon
Dominant language
Jupyter Notebook
Stars
7.3k
Forks
833
Avg merge
5h 11m
Merged PRs (30d)
5

Description

This issue tracks updates the `nlp_seq` example to follow practices outlined in #231.

- [ ] Port to linen API - once ported all subsequent changes should be done in `linen_examples/nlp_seq`
- [ ] Update `README.md` (links to paper, command line, TensorBoard metrics)
- [ ] Add `requirements.txt`
- [ ] Update file structure (separate `main.py`, `configs/` directory)
- [ ] Use `ml_collections.ConfigDict`
- [ ] Add benchmark test (optional)
- [ ] Add unit test
- [ ] Add Colab (optional)
- [ ] Adhere to Google Python style
- [ ] Shorten/beautify training loop (consider using `clu` for this)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.