google / google/flax

switching to _src structure

Open
#2,814 0 comments 0 reactions 0 assignees View on GitHub
Priority: P2 - no schedule
Dominant language
Jupyter Notebook
Stars
7.3k
Forks
833
Avg merge
5h 11m
Merged PRs (30d)
5

Description

@jheek mentioned: "this refactor [#2807]...was rolled back because somebody imports the ones initializer from nn.linen.attention. I have seen more of these odd dependencies on Flax lately. I think we should prioritize switching to a _src structure so we don't accidentally have users depending on private APIs and module imports"

Another example I noticed is someone importing `lecun_normal` and `zeros` initializers from [`linen.linear`](https://github.com/google/flax/blob/main/flax/linen/linear.py#L21) instead of `linen.initializers`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.