Python gen for array within struct not set to staticmethod for length/isnone
Open
- Dominant language
- C++
- Stars
- 26.5k
- Forks
- 3.7k
- PR merge metrics
- No merged PRs in 30d
Description
The ...Length and ...IsNone functions are constant for an array within a struct (which is kind of the point I think?) so the functions should be static in the py and pyi. These are located:
https://github.com/google/flatbuffers/blob/bab10754d93d74d1ff44d46de63558bc4127f7d8/src/idl_gen_python.cpp#L481-L482
https://github.com/google/flatbuffers/blob/bab10754d93d74d1ff44d46de63558bc4127f7d8/src/idl_gen_python.cpp#L804
and
https://github.com/google/flatbuffers/blob/bab10754d93d74d1ff44d46de63558bc4127f7d8/src/idl_gen_python.cpp#L825
Contributor guide
Assessment
This issue has not been assessed yet.