google / google/flatbuffers

[c++] idl.h ERROR enum conflicts with windows define

Open
#8,483 7 comments 0 reactions 1 assignee Claimed by @jtdavis777 View on GitHub
c++
Dominant language
C++
Stars
26.5k
Forks
3.7k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/google/flatbuffers/commit/f8380178600ff8255cc47694bddb321b2a9f648b https://github.com/wine-mirror/wine/blob/f2eebf36266fa0c3809472701763a6e468cd5ba3/include/wingdi.h#L1598

The result is a compile error if you reference both
1>/sdk/flatbuffers/24.3.25/include\flatbuffers/idl.h(636,49): error : expected identifier
1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\wingdi.h(118,29): message : expanded from macro 'ERROR'

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.