google / google/filament

BACKEND_OPENGL_VERSION_GL tested but header not included

Open
#9,735 1 comment 0 reactions 1 assignee Claimed by @pixelflinger View on GitHub
build linux
Dominant language
C++
Stars
20.5k
Forks
2.3k
Avg merge
2d 16h
Merged PRs (30d)
74

Description

For context, on line 38, it checks for `#if defined(BACKEND_OPENGL_VERSION_GL)` to determine if we're dealing with OpenGL or GLES. However, BACKEND_OPENGL_VERSION_GL is only defined in gl_headers.h. Without including this header, this define is never set and, therefore, this class will always assume it's only for GLES.

_Originally posted by @haroonq in https://github.com/google/filament/issues/9724#issuecomment-3930412838_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.