google / google/filament

LightManager.Builder.castLight=false not disabling emitted light

Open
#8,427 4 comments 0 reactions 1 assignee Claimed by @pixelflinger View on GitHub
documentation
Dominant language
C++
Stars
20.5k
Forks
2.3k
Avg merge
2d 14h
Merged PRs (30d)
83

Description

⚠️ **Issues not using this template will be systematically closed.**

**Describe the bug**
LightManager.Builder.castLight functionally does nothing as far as I can tell. I've tried this with DIRECTIONAL, POINT, and SUN lights.

**To Reproduce**
Steps to reproduce the behavior:
1. Use LightManager.Builder to build a DIRECTIONAL light.
2. Ensure that you specify castShadows(true)
3. Ensure that you specify castLight(false) on the builder
4. (optional) Set the light intensity to something obscene; something that would be noticeable if it were emitting light.
5. Add the light to the scene, etc...

**Expected behavior**
As the code documentation suggests, I expect to see shadows, but no light emitted.
_"In some situations it can be useful to have a light in the scene that doesn't actually emit light, but does cast shadows."_

**Smartphone (please complete the following information):**
- Device: Samsung Galaxy Tab S8+ (tablet)
- OS: Android 14.0

**Additional context**
This can also be seen on an emulated Android 14 device in Android Studio with an OpenGL pipeline on a RTX 2080

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.