google / google/filament

Typos in the discrete form of the rendering equation

Open
#4,784 2 comments 0 reactions 1 assignee Claimed by @pixelflinger View on GitHub
documentation
Dominant language
C++
Stars
20.5k
Forks
2.3k
Avg merge
2d 16h
Merged PRs (30d)
74

Description

Dear Filament team,

Recently when I was reading your documentation I found some potential typos in some of the equations in it.
https://google.github.io/filament/Filament.html#toc5.3.4.2.2 equation 82 and https://google.github.io/filament/Filament.html#mjx-eqn-iblSampling equation 124
Both of them are missing 2PI in the equations, as the integrand needs to be multiplied by the integral domain(which is 2PI as the hemisphere surface area) over the sample count. So I think it should be 2PI/N rather than 1/N.

Could you confirm if they are typos or why the 2PI is absent in the equations please?

Many thanks
Anning

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.