google / google/filament

Out-of-gamut colors produced by inverse tone mapping cause hue shifts

Open
#3,909 8 comments 0 reactions 1 assignee Claimed by @romainguy View on GitHub
Dominant language
C++
Stars
20.5k
Forks
2.3k
Avg merge
2d 16h
Merged PRs (30d)
74

Description

Hello!
As stated in this issue in the maintained Sceneform repository (https://github.com/ThomasGorisse/sceneform-android-sdk/issues/60) the `inverseTonemapSRGB` function makes the colors with the full pixel intensity appear incorrectly. Is it because the `inverseTonemapSRGB` function is an approximation and isn't suitable for converting colors from the sRGB space to the linear space (I think that is why it is used in the `ViewRenderable` material in Sceneform)?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.