google / google/ever

cmake policy issue in `CMakeLists.txt`

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
17
Forks
5
PR merge metrics
No merged PRs in 30d

Description

(edited because my initial assumption about what was going on was wrong)

Trying to build ever through `ever-training` `install.bash` fails on line 34 of `CMakeLists.txt` because of `cmake_policy(VERSION 2.8.12)` being deprecated (?)

chatgpt says I should update that to be `cmake_policy(VERSION 3.7)` but I'm unsure if there are downstream impacts because I'm getting failures elsewhere in the installation as well

---
Another edit:

Turns out it is due to cmake 4. I had missed cmake getting installed a second time by pip in `ever-training` Dockerfile. Will make a PR there to make sure it's less than 4 and I would suggest adding that to the instructions here as well

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.