google / google/error-prone

Link to ErrorProne has trailing parenthesis

Open
#5,132 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

Example job failure in GitHub (https://github.com/mockito/mockito/actions/runs/15985352598/job/45088589864?pr=3674):

```
> Task :mockito-extensions:mockito-junit-jupiter:retryTest SKIPPED
/home/runner/work/mockito/mockito/mockito-core/src/test/java/org/mockito/internal/util/collections/HashCodeAndEqualsSafeSetTest.java:136: error: [SelfAssertion] You are passing identical arguments to the isEqualTo method, so this assertion always passes. THIS IS LIKELY A BUG! If you are trying to test the correctness of an equals() implementation, use EqualsTester instead.
assertThat(set).isEqualTo(set);
^
(see https://errorprone.info/bugpattern/SelfAssertion)

> Task :mockito-core:compileTestJava
/home/runner/work/mockito/mockito/mockito-core/src/test/java/org/mockitousage/basicapi/ReplacingObjectMethodsTest.java:36: error: [SelfAssertion] You are passing identical arguments to the isEqualTo method, so this assertion always passes. THIS IS LIKELY A BUG! If you are trying to test the correctness of an equals() implementation, use EqualsTester instead.
assertThat(mock).isEqualTo(mock);
^
(see https://errorprone.info/bugpattern/SelfAssertion)
```

When I click on this link in the GitHub output, it leads to `https://errorprone.info/bugpattern/SelfAssertion)`. Which as you can see has the trailing parenthesis included.

Can we add a space before the closing parenthesis such that the URL is properly clickable?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.