google / google/error-prone

Allow to defuse `-XepDisableAllChecks` by `-XepEnableAllChecks` if it is present in javacopts later.

Open
#4,474 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

We have a particular toolchain config that contains `-XepDisableAllChecks` to speed build up a little. We want to be able to enable checks for certain targets but providing extra javacopt value.

As of now there are plenty of settings that disabling certain parts of EP yet there is no way to negate those disablements if we want to do this on target level.

```
default_java_toolchain(
name = "javac_toolchain_%d" % (release),
configuration = DEFAULT_TOOLCHAIN_CONFIGURATION,
source_version = "%s" % release,
target_version = "%s" % release,
package_configuration = [
":disable_warnings",
":parameters_for_spring",
":debug",
],
java_runtime = Label("...."),
jvm_opts = BASE_JDK9_JVM_OPTS + ["-Xss4m", "-XX:-MaxFDLimit"],
javacopts = DEFAULT_JAVACOPTS,
visibility = ["//visibility:public"],
)

disable_warning_javac_opts = [
"-Xlint:none",
"-nowarn",
"-XepDisableWarningsInGeneratedCode",
]
if no_error_prone:
disable_warning_javac_opts += ["-XepDisableAllChecks"]
java_package_configuration(
name = "disable_warnings",
javacopts = disable_warning_javac_opts,
packages = ["...:all_packages"],
)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.