google / google/error-prone

CheckReturnValue and ReturnValueIgnored have overlapping altNames

Open
#3,929 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

`CheckReturnValue` has altNames: `"ResultOfMethodCallIgnored", "ReturnValueIgnored"`
`ReturnValueIgnored` has altNames: `"ResultOfMethodCallIgnored", "CheckReturnValue"`

I'm unclear on the correctness of this, but am encountering a bug as I'll describe below.

With this change to allow sev overrides by altNames: https://github.com/google/error-prone/commit/48bbef0e51c2f5098efe6a2587fafc0ebc31bca5

this conflicting overlap makes it impossible to address one and not the other.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.