google / google/error-prone

StringSplitter Pattern not Consistently Detected

Open
#3,440 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

**Expected**: Code snippet that uses `String.split(String)`, e.g. `"me:you".split(":")`, should consistently trigger [StringSplitter](https://errorprone.info/bugpattern/StringSplitter) pattern.
**Actual**: When passed as parameter into certain other methods `List.of(T...)`, `Stream.of(T...)`, `Arrays.asList(T...)` and `Assertions.assertThat(T[])` (from AssertJ), the above snippet does not trigger StringSplitter (please see minimal example project at https://github.com/iadcode/sample-string-splitter).

**JDK**: 11.0.16.1 (also observed on 17.0.4.1)
**Maven**: 2.8.6
**Errorprone Maven Plugin**: 2.15.0

**Screenshots of Compiling Example Project**
Test Case 1 - StringSplitter is triggered
![189276130-1bd357f7-7648-4c81-abf0-9b814fd02bae](https://user-images.githubusercontent.com/18545429/189279912-145e0c9d-7c66-4bed-8c44-5f720c730ecf.png)

Test Case 2 - StringSplitter not triggered
![189276181-02f0a151-b1dc-4fc0-86d6-0386524046fe](https://user-images.githubusercontent.com/18545429/189279890-1ca8170b-9fa1-4359-aebe-0698c6e94ca6.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.