google / google/error-prone

Var: False positves

Open
#3,418 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

I don't see anything that would suggest any of these should be resolved to mutable.

```java
package com.xenoterracide.ppm.transactional.dataloaders;

import com.netflix.graphql.dgs.DgsDataLoader;
import com.xenoterracide.ppm.transactional.domainmodel.repositories.ExceptionRepository;
import com.xenoterracide.ppm.transactional.types.Exception;

import java.util.List;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionStage;
import java.util.stream.Collectors;
import org.dataloader.BatchLoader;

@DgsDataLoader
public class ExceptionDataLoader implements BatchLoader {

private final ExceptionRepository repository;

ExceptionDataLoader(ExceptionRepository repository) {
this.repository = repository;
}

@Override
public CompletionStage> load( List keys) {
return CompletableFuture.supplyAsync(() -> {
return this.repository.findAllById(keys).map(e -> {
return Exception.newBuilder().id(String.valueOf(e.getId())).build();
}).collect(Collectors.toList());
});
}
}
```

```
^
(see https://errorprone.info/bugpattern/Var)
Did you mean '@Var var entity = new ExceptionEntity();'?
/Users/nqy642/IdeaProjects/iw-pm-backend/module/controller/transactional/src/main/java/com/xenoterracide/ppm/transactional/dataloaders/ExceptionDataLoader.java:23: error: [Var] Non-constant variable missing @Var annotation
ExceptionDataLoader(ExceptionRepository repository) {
^
(see https://errorprone.info/bugpattern/Var)
Did you mean 'ExceptionDataLoader(@Var ExceptionRepository repository) {'?
/Users/nqy642/IdeaProjects/iw-pm-backend/module/controller/transactional/src/main/java/com/xenoterracide/ppm/transactional/dataloaders/ExceptionDataLoader.java:28: error: [Var] Non-constant variable missing @Var annotation
public CompletionStage> load(List keys) {
^
(see https://errorprone.info/bugpattern/Var)
Did you mean 'public CompletionStage> load(@Var List keys) {'?
/Users/nqy642/IdeaProjects/iw-pm-backend/module/controller/transactional/src/main/java/com/xenoterracide/ppm/transactional/dataloaders/ExceptionDataLoader.java:30: error: [Var] Non-constant variable missing @Var annotation
return this.repository.findAllById(keys).map(e -> {
^
(see https://errorprone.info/bugpattern/Var)
Did you mean 'return this.repository.findAllById(keys).map(@Var e -> {'?
16 errors
2 warnings
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.