google / google/error-prone

MustBeClosedChecker Mockito matcher is missing some cases that should be suppressed

Open
#3,347 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

Assuming that we have the following code:
```
class SomeClass {
@MustBeClosed
Closeable someMethod() {
return new AutoCloseable() {
public void close() {};
};
}
}
```

Two examples of code that are still being flagged by the checker are:
```
SomeClass instance = new SomeClass();
Mockito.lenient().when(instance).someMethod();
```

```
SomeClass instance = new SomeClass();
Mockito.verify(instance).someMethod();
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.