google / google/error-prone

Suggest update Maven installation to use profiles

Open
#2,775 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

When trying to apply the installation instructions to a multi-JDK build project, I ran into cases where the specific JDK logic could not be used uniformly. I ended up just dropping it out of JDK 8, but kept it for JDK 9 and JDK 17 using the instructions for JDK 16, but I had to wrap it all in [Maven profiles](https://maven.apache.org/guides/introduction/introduction-to-profiles.html), a la

```


java9

[9,)






```

Perhaps consider replacing the per-JDK instructions with a single ``-based approach, with specific XML comments to indicate what consumers could pull out if they don't care about multi-JDK support. This would have the benefit that if they do float from an older version to a newer version, at least ErrorProne won't break on them.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.