google / google/error-prone

New check: result of CountDownLatch.await(timeout, TimeUnit) is not checked

Open
#1,490 5 comments 4 reactions 0 assignees View on GitHub
Type-NewCheck
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

### Description of the problem / feature request:

`CountDownLatch.await(timeout, unit)` result must alwasy be checked.

### Feature requests: what underlying problem are you trying to solve with this feature?

This almost always happens in tests, resulting in tests which don't actually test the production logic.

grpc-java: https://github.com/grpc/grpc-java/issues/6663
Flink: https://issues.apache.org/jira/browse/FLINK-15838
Druid: https://github.com/apache/druid/issues/9285

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.