google / google/error-prone

Check Asserts.assertEquals()

Open
#115 0 comments 0 reactions 0 assignees View on GitHub
migrated Priority-Medium Type-NewCheck
Dominant language
Java
Stars
7.2k
Forks
820
Avg merge
5h 9m
Merged PRs (30d)
50

Description

_[Original issue](https://code.google.com/p/error-prone/issues/detail?id=115) created by **fmcwilliams@google.com** on 2013-04-02 at 08:30 PM_

---

Bug pattern: assertEquals() calls that are technically legal but produce misleading error messages.

Good patterns:

assertEquals("constant", myVar);
assertEquals(123, myInt);

checkMoney(myMoney, 12500000L, "USD");
...
private void checkMoney(Money money, long expectedMicros, String expectedCurr) {
  assertEquals(expectedMicros, money.getMicros());
  assertEquals(expectedCurr, money.getCurrencyCode());
}

Bad patterns:

assertEquals(myVar, "constant");
assertEquals(myInt, 123);

checkMoney(myMoney, 12500000L, "USD");
...
private void checkMoney(Money money, long expectedMicros, String expectedCurr) {
  assertEquals(money.getMicros(), expectedMicros);
  assertEquals(money.getCurrencyCode(), expectedCurr);
}

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.