google / google/emboss

Optimize C++ generated code to skip condition checks for unconditionally present fields

Open
#249 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
92
Forks
30
PR merge metrics
No merged PRs in 30d

Description

As discussed in PR #241, we should optimize the `Ok()` method generation to skip `if-block` wrappers for fields that are unconditionally present (where the condition is statically known to be true).

This reduces the size and complexity of the generated C++ headers, but introduces golden file churn which makes it better suited as a separate issue and PR.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.