google / google/emboss

Packing structures with `$next` is unintuitive after conditional blocks

Open
#191 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
92
Forks
30
PR merge metrics
No merged PRs in 30d

Description

I've recently reviewed a handful of Emboss definitions where the author intends to tightly pack a struct with `$next`, but doing so after conditional blocks leaves a "gap" in the structure so that it is not tightly packed. This has been surprising for the author each time, and it seems like this behavior is a bit unintuitive.

We should consider either updating `$next` to handle this case as the author likely intends or, if this behavior must be maintained for backward-compatibility, provide an alternative built-in for doing this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.