google / google/elemental2

Type of Object.groupBy and its callback wrong

Open Beginner friendly
#187 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
170
Forks
41
PR merge metrics
No merged PRs in 30d

Description

https://github.com/google/closure-compiler/blob/f2cc20715e86c7dafd6de0f9e06eb2da693903f3/externs/es6.js#L2456

produces multiple signatures that are incorrect. Looks like it was interpreted as

`[ function(T, number=): string ] |symbol|number`

rather than

`function(T, number=): [ string|symbol|number ]`

Contributor guide

Open the contributing guide

Research direction

Start with the referenced externs/es6.js at line 2456 and inspect how Object.groupBy and its callback are declared. Update the signatures so the callback returns a string, symbol, or number and verify that generated or checked Elemental2 types expose that shape without producing multiple incorrect signatures.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, javascript
Domain
api, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.