google / google/draco

unreachable code

Open
#960 0 comments 0 reactions 1 assignee Claimed by @tomfinegan View on GitHub
bug
Dominant language
C++
Stars
7.5k
Forks
1.1k
Avg merge
47m
Merged PRs (30d)
1

Description

/src/draco/io/gltf_encoder.cc line 3414
Code:
// Encode the geometry into a buffer.
EncoderBuffer buffer;
DRACO_RETURN_IF_ERROR(EncodeToBuffer(geometry, &gltf_asset, &buffer));
if (extension == "glb") {
return WriteGlbFile(gltf_asset, buffer, filename);
}
return WriteGltfFiles(gltf_asset, buffer, filename, bin_filename,
resource_dir);
return OkStatus(); /// <- unreachable
}

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.