google / google/draco

Clang and GCC: Large number of warnings at -Wall

Open
#673 0 comments 0 reactions 0 assignees View on GitHub
bug cmake low priority
Dominant language
C++
Stars
7.5k
Forks
1.1k
Avg merge
47m
Merged PRs (30d)
1

Description

Draco also cannot be built or used using Clang or GCC with -Wall -Werror

This makes it rather difficult (and noisy) to integrate into many modern projects, as it is often recommended to have -Wall -Werror enabled.

The warnings I have disabled to build 1.4.1 are:
"-Wno-absolute-value"
"-Wno-bool-compare"
"-Wno-comment"
"-Wno-maybe-uninitialized"
"-Wno-sign-compare"
"-Wno-unused-local-typedefs"

It also appears that the following warnings must be disabled via pragma in order to use the library for glTF:
"-Wno-bool-compare"
"-Wno-sign-compare"

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.