MSVC2019 - Large number of warnings at /W1 and higher (1.4.1 release)
- Dominant language
- C++
- Stars
- 7.5k
- Forks
- 1.1k
- Avg merge
- 47m
- Merged PRs (30d)
- 1
Description
I'm currently trying to add Draco support to an existing cmake project which compiles on MSVC2019 using /W4 /WX
(Warning level 4, warnings-as-errors.)
Unfortunately the Draco libraries produce a very large number of warnings, even at /W1, and so cannot be compiled with /WX at all.
Common warnings:
- C4018 signed/unsigned mismatch (W3)
- C4100 unreferenced formal parameter (W4)
- C4146 unary minus operator applied to unsigned type (W2)
(These are almost certainly real bugs, eg parser_utils.cc line 154 will always be positive!)
- C4244, C4267 conversion with possible loss of data (W2, W3, W4)
- C4661 no suitable definition for explicit template instantiation (W1)
- C4804 unsafe use of bool (W1)
It would be good if the Draco library could be compiled in MSVC2019 with /WX set.
Contributor guide
Assessment
This issue has not been assessed yet.