google / google/draco

The library fails to install under certain paths.

Open
#1,132 0 comments 0 reactions 0 assignees View on GitHub
bug cmake
Dominant language
C++
Stars
7.5k
Forks
1.1k
Avg merge
47m
Merged PRs (30d)
1

Description

The CMake code below (from the file cmake/draco_install.cmake) requires `draco_src_root` to be a regex, which rules out certain valid strings for paths:
[list(TRANSFORM draco_api_includes REPLACE "${draco_src_root}/" "")](https://github.com/google/draco/blob/main/cmake/draco_install.cmake#L42)

Contributor guide

Open the contributing guide

Research direction

Read cmake/draco_install.cmake at line 42 and trace how draco_src_root is used by the list(TRANSFORM ... REPLACE) operation. Reproduce installation with a path that currently fails; done means valid installation paths are handled without unintended regex interpretation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.