google / google/dopamine

Missing kernel init on Impala convolution layers wanted?

Open
#231 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
10.9k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

Hi,

Thanks again for the amazing code base!

The second and third definitions of the convolution layers are missing the initializer type, while the initializer type is defined earlier. Is that wanted?
https://github.com/google/dopamine/blob/bec5f4e108b0572e58fc1af73136e978237c8463/dopamine/jax/networks.py#L87-L89

Looking at the original code of BBF, the kernel init was specified for the same convolution layers:
https://github.com/google-research/google-research/blob/89dbaf2657e70797f2dea7a6acac5a808da8ff4d/bigger_better_faster/bbf/spr_networks.py#L557

Best,
Théo Vincent

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.