google / google/dopamine

Minor bug for `frame_skip` at `AtariPreprocessing`

Open
#177 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
10.9k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

When setting `frame_skip=1` in the `AtariPreprocessing`, we will always have `t=1` in the *step* function (line 475 of `atari_lib.py`). And so, `self.screen_buffer[0]` never gets updated.
Now considering the `_pool_and_resize` when `frame_skip` is one, `transformed_image` is exactly the resized `self.screen_buffer[0]`, and so, it will never change in the entire episode.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.