google / google/digitalbuildings

Revisit if using both SFSS and SFVSC is necessary

Open
#1,117 1 comment 0 reactions 1 assignee Claimed by @cstirdivant View on GitHub
Ontology Model
Dominant language
Python
Stars
461
Forks
178
Avg merge
9h 26m
Merged PRs (30d)
5

Description

SFVSC (and other speed control types) require the run status and command field, therefore including SFSS is extraneous.

We should either:
- Remove run_command and run_status as required on the VSC types
- Revise precedent so that if a canonical type uses a VSC type it does not need the SS type (explore if this has ramifications for downstream analytics)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.