google / google/cro3

As in #117, use the "script" command to force strange stdout to behave and handle terminal/non terminal cases

Open
#120 0 comments 0 reactions 0 assignees View on GitHub
P2
Dominant language
Rust
Stars
50
Forks
18
PR merge metrics
No merged PRs in 30d

Description

As in PR #117 , we use the `script` command to force sub processes to behave and print out.

Right now in that case we simply forward stdout to stdout and ignore our tracing logging system (which in the future may cause issues when trying to see the logs of subprocesses).

I propose reintroducing the changes removed in #111 and handle these cases in two ways:

1. If we are running in a terminal do as PR #117 did and forward directly, providing a good terminal experience
2. if we are running outside of a TTY, transform \r characters into \n characters and log to a file and tracing

This way the logs contain teh lgos of subproceses, and create files that can be uploaded directly to some system if it becomes dependent on lium

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.