google / google/copybara

Docker entrypoint does not pass on command line arguments

Open
#158 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
3.8k
Forks
345
PR merge metrics
No merged PRs in 30d

Description

The Docker entrypoint does not pass command line arguments that are given to `docker run`:

https://github.com/google/copybara/blob/a66f59c5898cda9a3a20ffceecfad1d0f506e456/.docker/entrypoint.sh#L17

This presents a problem for running workflows that accept command line arguments.

Further, I'm unclear why `COPYBARA_*` env vars were preferred over simply doing something like:

```
java -jar /opt/copybara/copybara_deploy.jar "$@"
```

Any pointers much appreciated.

Thanks

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.