google / google/conscrypt

Simplify shading of conscrypt

Open
#811 1 comment 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Java
Stars
1.4k
Forks
326
Avg merge
16h 22m
Merged PRs (30d)
17

Description

Currently users who would like to shade conscrypt are required to build the package with the JNI_JARJAR_PREFIX defined which requires all shading of conscrypt to know how to build conscrypt in the first place.

This could be simplified by adopting the pattern done by tcnative where the package prefix path for JNI is [parsed from the library name](https://github.com/netty/netty-tcnative/blob/9fd38de8a07cc413b83cacf39470f2845a68e26c/openssl-dynamic/src/main/c/jnilib.c#L233) allowing for shading of conscrypt without needing to rebuild a custom version.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.