google / google/conscrypt

Redundant executable check for native library

Open
#741 2 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
1.4k
Forks
326
Avg merge
16h 22m
Merged PRs (30d)
17

Description

When loading the library from the temporary directory it is checked (introduced in e7a7547d2268cf1286bf314ab929ceda7a345e64) if executable permission bits can be applied in `Platform.canExecuteExecutable`. The check fails in a sandboxed environment on macOS where `Files.isExecutable()` always returns `false` (possibly a bug). Nevertheless, at least on macOS the dynamic library must not be executable to be successfully loaded subsequently. The check could be omitted alltogether. Don't know if this is a requirement on other platforms.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.