google / google/conscrypt

Remove SslWrapper.toSSLSession

Open
#350 0 comments 0 reactions 1 assignee Claimed by @davidben View on GitHub
Dominant language
Java
Stars
1.4k
Forks
326
Avg merge
16h 22m
Merged PRs (30d)
17

Description

Filing this for myself, though I might not get to it just yet. The session refactor didn't quite remove the `SSL_SESSION`-based Java session object. We should be able to treat `SSL_SESSION` as largely opaque and avoid duplicating accessors between `SSL` and `SSL_SESSION`:

1. Use the ActiveSession as the session parameter to putSessionData. It's just being used as a session cache key.
2. Either make AbstractSSLSession.getSession never return anything like Netty or have it return an object with no properties at all. It's really not a useful function.
3. Fix the session format to remove the redundant copies of OCSP and SCT fields.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.